Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Fix side nav text alignment after adding start page #3015

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 7, 2020

/cc @rui5i
Thanks for finding out the problem.
After the fix:
z0KVn43Fekm
Before the fix:
goucWXebTsQ


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Bobgy Bobgy added the lgtm label Feb 7, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 8, 2020

/retest

3 similar comments
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 8, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 8, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 8, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit f0d96b7 into kubeflow:master Feb 8, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Fix side nav text alignment after adding start page

* Fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants