Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numerology to SDK owner #3006

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Add numerology to SDK owner #3006

merged 1 commit into from
Feb 7, 2020

Conversation

numerology
Copy link

@numerology numerology commented Feb 6, 2020

This change is Reviewable

@numerology
Copy link
Author

/assign @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 6, 2020

It's fun how I had the same thought to add you to to the SDK owners just an hour ago (sorry, got busy with some bugs) =)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

It's fun how I had the same thought to add you to to the SDK owners just an hour ago (sorry, got busy with some bugs) =)

/lgtm
/approve

Lol thanks! @Ark-kun

@numerology
Copy link
Author

/retest

1 similar comment
@numerology
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1e2b3b6 into master Feb 7, 2020
@numerology numerology deleted the numerology-patch-2 branch February 8, 2020 00:30
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants