Allow blank port for minio client to work with S3 #2996
Conversation
Background
---
As of current, supplying a minioServiceHost of `s3.amazonaws.com` with
any port incurs an error.
Per the results of:
```
testBucket := func(hostPort string) error {
client, _ := minio.New(hostPort, accessKey, secretKey, false)
_, err := client.BucketExists(bucket)
return err
}
for _, endpoint := range []string{
"s3.amazonaws.com:443",
"s3.amazonaws.com:80",
"s3.amazonaws.com:",
"s3.amazonaws.com",
} {
fmt.Printf("Endpoint: %s, Error: %v\n", endpoint, testBucket(endpoint))
}
```
```
Endpoint: s3.amazonaws.com:443, Error: Get http://s3.amazonaws.com:443/kflow-test/?location=: net/http: HTTP/1.x transport connection broken: malformed HTTP response "\x15\x00\x00\x00\x02\x01\x00"
Endpoint: s3.amazonaws.com:80, Error: Head http://s3.amazonaws.com/kflow-test/: 301 response missing Location header
Endpoint: s3.amazonaws.com:, Error: Head http://s3.amazonaws.com/kflow-test/: 301 response missing Location header
Endpoint: s3.amazonaws.com, Error: <nil>
```
Only the connection without a port specified works.
This change allows passing a blank port to support this.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Hi @pavanaiyar. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
/assign @IronPan |
|
/assign neuromage |
|
/ok-to-test
|
|
/retest |
|
@Ark-kun Thanks for reviewing.
As far as I'm aware it's a regular ol' http/https service that'll default to 80/443. All examples on minio specify the legacy global endpoint |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Background
---
As of current, supplying a minioServiceHost of `s3.amazonaws.com` with
any port incurs an error.
Per the results of:
```
testBucket := func(hostPort string) error {
client, _ := minio.New(hostPort, accessKey, secretKey, false)
_, err := client.BucketExists(bucket)
return err
}
for _, endpoint := range []string{
"s3.amazonaws.com:443",
"s3.amazonaws.com:80",
"s3.amazonaws.com:",
"s3.amazonaws.com",
} {
fmt.Printf("Endpoint: %s, Error: %v\n", endpoint, testBucket(endpoint))
}
```
```
Endpoint: s3.amazonaws.com:443, Error: Get http://s3.amazonaws.com:443/kflow-test/?location=: net/http: HTTP/1.x transport connection broken: malformed HTTP response "\x15\x00\x00\x00\x02\x01\x00"
Endpoint: s3.amazonaws.com:80, Error: Head http://s3.amazonaws.com/kflow-test/: 301 response missing Location header
Endpoint: s3.amazonaws.com:, Error: Head http://s3.amazonaws.com/kflow-test/: 301 response missing Location header
Endpoint: s3.amazonaws.com, Error: <nil>
```
Only the connection without a port specified works.
This change allows passing a blank port to support this.
Background
As of current, supplying a minioServiceHost of
s3.amazonaws.comwithany port incurs an error.
Per the results of:
Only the connection without a port specified works.
This change allows passing a blank port to support this.
This change is