Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Init Action #2980

Merged
merged 3 commits into from
Feb 4, 2020
Merged

fix for Init Action #2980

merged 3 commits into from
Feb 4, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 4, 2020 •
edited
Loading

  1. work for "mpdev verify"
  2. correct exit code
  3. check whether already created

This change is Reviewable

@rmgogogo rmgogogo changed the title fix for "mpdev verify" [WIP] fix for "mpdev verify" Feb 4, 2020
@rmgogogo rmgogogo changed the title [WIP] fix for "mpdev verify" fix for Init Action Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 545de31 into kubeflow:master Feb 4, 2020
@numerology numerology mentioned this pull request Feb 4, 2020
Closed
2 tasks
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@rmgogogo @Jeffwan
fix for Init Action (kubeflow#2980)
d391f79 
* should can work

* didn't delete configmap for mpdev verify

* done

Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@sivanantha321
Bump torchserve version to 0.8.0 (kubeflow#2980)
b795d98 
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmgogogo @k8s-ci-robot