Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diagnose me component to XGboost sample #2953

Merged
merged 17 commits into from
Feb 1, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jan 31, 2020

changing the output type to GCPProjectID to match XGBoost input type


This change is Reviewable

@SinaChavoshi SinaChavoshi changed the title diagnose me component [WIP] diagnose me component & XGBoost pipeline updates Jan 31, 2020
@SinaChavoshi SinaChavoshi changed the title [WIP] diagnose me component & XGBoost pipeline updates Diagnose me component updates Jan 31, 2020
@SinaChavoshi
Copy link
Contributor Author

/retest

@SinaChavoshi SinaChavoshi changed the title Diagnose me component updates [WIP] Diagnose me component updates Jan 31, 2020
@SinaChavoshi SinaChavoshi changed the title [WIP] Diagnose me component updates Adding diagnose me component to XGboost sample Jan 31, 2020
@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 1, 2020

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 1, 2020
@numerology
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 1, 2020
@jessiezcc
Copy link
Contributor

/lgtm

@SinaChavoshi
Copy link
Contributor Author

/retest

1 similar comment
@SinaChavoshi
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 13dd20b into kubeflow:master Feb 1, 2020
@SinaChavoshi SinaChavoshi deleted the GXBoost_diagnose_me branch February 7, 2020 15:54
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* adding diagnose me component

* Updating component with execution flag

* chaning return type to match XGBOOST Pipeline

* changing the diagnose_me output type

* changing the diagnose_me output type

* reverting changes on XGBoost.py

* reverting changes in Xgboost_trainer

* remvoing raise error with flag

* upadating error message

* Adding support for project_id verification

* updating xgboost to add verification component

* chang project name validation

* chang project name validation

* changing the component to load from latest yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants