[Backend] Patch default bucket name and project ID #2938
Conversation
numerology
changed the title
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
…atch-default-gcs
|
/retest |
|
/assign @IronPan |
| } | ||
| pipelineFile, err = server.PatchPipelineDefaultParameter(pipelineFile, patchMap) | ||
| if err != nil { | ||
| return fmt.Errorf("Failed to patch default value to %s. Error: %v", config.Name, err) |
There was a problem hiding this comment.
If patching fails, will APIserver keep restarting?
There was a problem hiding this comment.
Yes it does. Do you recommend swallow the error? IMO patching should work unless user configured something in the wrong way. Thanks!
|
/retest |
1 similar comment
|
/retest |
manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml
Outdated
Show resolved
Hide resolved
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-frontend-test |
* update branch * add env var * update api-server * populate default value * lint * bump build rule * bump build rule * bump travis bazel version * fix * Revert "bump travis bazel version" This reverts commit 92db384 * Revert "bump build rule" This reverts commit be2bd7b * Revert "bump build rule" This reverts commit 78926e3 * Revert "fix" This reverts commit 963e64b * fix * patch all the samples * unittest * fix tests * minor fix * style change * clean up
Depends on #2932 .
Test pendingVerified it's working at https://736bf3ceb05ded92-dot-us-central2.pipelines.googleusercontent.com/#/pipelines
This change is