[UI] Getting started page for hosted pipelines #2935
Conversation
Bobgy
force-pushed
the
fe_started_page
branch
from
ba1441a
to
3dd28bd
Compare
|
/approve |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-sample-test strange, flakiness rate of workload identity seems to be higher than before |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/assign @joeliedtke Thanks for asking for a tech writer review, @Ark-kun! I've assigned @joeliedtke, as he's now the tech writer for Pipelines. (I'm continuing as the Kubeflow tech writer overall.) |
|
/uncc |
|
Thank you for adding this page! The page looks nice and useful, but I've noticed that it misses a link to the Pipelines documentation (https://www.kubeflow.org/docs/pipelines/), the Quickstart, the Getting Started guide etc. We might want to link to that helpful information. |
|
Thanks @Bobgy for this PR, it looks great! |
|
@Ark-kun, FYI, the page is currently only a mockup to demonstrate markdown. I expect a separate PR to adjust the exact content. @jessiezcc, pipelines page still shows preloaded pipelines. I don't see how we can distinguish preloaded from user uploaded. So that's something I couldn't implement now. |
|
for now, can we differentiate using prefix such as [demo], [tutorial]? WDUT, @SinaChavoshi ? |
|
@jessiezcc thanks for the idea. I think that's doable, but would need quite some efforts. I'm not sure I can fit that in current time frame. Also, when I was trying to test filtering, found a bug with it: #2945. We should fix this before beta. |
|
Note, content of this getting started page is purely rendered from markdown here: https://github.com/kubeflow/pipelines/pull/2935/files#diff-1e8357336f0f74b158fbf0751ac2d9daR31. So it's super easy for anyone to update later. I suggest we get this merged and let someone in US time work on the final tech writings. So that communication loop would be minimized. @SinaChavoshi can I ask you for that? |
|
agree, let's check in this first |
|
Yuan thank you again for all the work, +1 lets get this in as is. We can do quick follow up to adjust the UI before build cut off date today. As Yuan mentioned changes from here will be trivial. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Implement getting started page. * Add feature flag to only show getting started page on hosted pipelines * Add tests * Fix format * Implement requested layout in getting started page * Minor adjust layout * Fix tests * Fix snapshots * Update page title
UPDATE: also implemented layout similar to designed documentation
UPDATE2: adjusted page title
Content of this page is purely rendered from markdown here: https://github.com/kubeflow/pipelines/pull/2935/files#diff-1e8357336f0f74b158fbf0751ac2d9daR31. So it's super easy for anyone to update later.
demo when feature flag turned on: https://drive.google.com/file/d/12dyaTLQY3AvwG38YC3TmBhCGOYqSUmGg/view
Changes:
exact content of this page is merely a copy from [WIP] UI changes for pipeline landing page #2928implemented requested layout, please adjust content with markdown based on further discussion).Feature flag verification:
This supercedes #2928.
/assign @SinaChavoshi
This change is