Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Added the create_component_from_func alias #2911

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 24, 2020

Added the create_component_from_func function as alias for func_to_container_op.
It behaves exactly the same, but the name now does not imply that you'll always get ContainerOp from it.


This change is Reviewable

Added the `create_component_from_func` function as alias for `func_to_container_op`.
It behaves exactly the same, but the name now does not imply that you'll always get `ContainerOp` from it.
Some function parameters are not added at this moment as they're not widely used and might be deprecated in the future.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 25, 2020

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 27, 2020

/retest

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 28, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6c72cc8 into kubeflow:master Jan 28, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…ow#2911)

Added the `create_component_from_func` function as alias for `func_to_container_op`.
It behaves exactly the same, but the name now does not imply that you'll always get `ContainerOp` from it.
Some function parameters are not added at this moment as they're not widely used and might be deprecated in the future.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…#2911)

* Allow using SSL between transformer and predictor/explainer

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update custom transformer example

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update document

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update doc and use f string format

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

---------

Signed-off-by: Jin Dong <jdong183@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants