Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add tooltips to table name columns so they can be read fully #2894

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 22, 2020

Demo: https://drive.google.com/file/d/1i_0mvv2u5nM1E9wSzER4DfYjy_dnhU4C/view
Address long existing problem: "names are too long to read in lists".
/area frontend
/kind feature
/assign @jingzhang36


This change is Reviewable

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 22, 2020

/approve

@jingzhang36
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c482d93 into kubeflow:master Jan 22, 2020
@Bobgy Bobgy deleted the ui_tooltip_on_table_name_column branch January 22, 2020 11:28
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…beflow#2894)

* Add tooltips to table name columns so they can be read fully

* Update test snapshot

* Fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants