Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sample doc links during backend image build #2880

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 20, 2020

Part of #2721 (comment)

/assign @numerology
/cc @Ark-kun


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 21, 2020

/test kubeflow-pipeline-sample-test

@numerology
Copy link

Thanks @Bobgy !

@numerology
Copy link

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 21, 2020

Thanks for review, also
/assign @jingzhang36
for backend review

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 21, 2020

/test kubeflow-pipeline-sample-test

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0577fe1 into kubeflow:master Jan 21, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Pin sample doc links during backend image build

* Update sample_config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants