Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - Metadata - Use custom properties in addition to plain properties #2854

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 16, 2020

Adapting to the recent TFX changes #2562 (comment)


This change is Reviewable

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good

@Bobgy
Copy link
Contributor

Bobgy commented Jan 16, 2020

Just want to double check, does the new UI work with current tfx sample?

@Bobgy
Copy link
Contributor

Bobgy commented Jan 16, 2020

/approve
/lgtm
/hold for backward compatibility confirmation, you can unhold once confirmed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Jan 16, 2020

Nevermind, I saw that you have always tried to use the old value first.
/hold cancel

@Ark-kun Ark-kun changed the title Frontend - Metadata - Use custom properties instead of plain properties Frontend - Metadata - Use custom properties in addition to plain properties Jan 16, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 16, 2020

This is currently a backwards compatible change.
The old properties are still used (I've corrected the title), so the UX will still work with the current TFX sample.
Without this change, the UX will stop working for the TFX sample once the TFX SDK updates.
/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 6cf8c47 into kubeflow:master Jan 16, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants