Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in Viewer cleanup #2853

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix panic in Viewer cleanup #2853

merged 1 commit into from
Jan 17, 2020

Conversation

mattnworb
Copy link
Contributor

@mattnworb mattnworb commented Jan 16, 2020 •
edited
Loading

addresses issue #2253.

Passing nil as an argument to the varargs ...DeleteOption parameter of client.Delete() will panic since client-go will iterate over the DeleteOption array and invoke each (since DeleteOption is defined as type DeleteOptionFunc func(*DeleteOptions).

This change is Reviewable

@mattnworb
fix panic in Viewer cleanup
b078982 
addresses issue kubeflow#2253. Passing `nil` as an argument to the varargs
`...DeleteOption` parameter of `client.Delete()` will panic since
client-go will iterate over the DeleteOption array and invoke each
(since DeleteOption is defined as
`type DeleteOptionFunc func(*DeleteOptions)`.
@k8s-ci-robot
Copy link
Contributor

Hi @mattnworb. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member

IronPan commented Jan 16, 2020

/ok-to-test

@IronPan
Copy link
Member

IronPan commented Jan 16, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattnworb
Copy link
Contributor Author

/retest

1 similar comment
@mattnworb
Copy link
Contributor Author

/retest

@mattnworb mattnworb mentioned this pull request Jan 16, 2020
Closed
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 17, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit c0153a0 into kubeflow:master Jan 17, 2020
@Bobgy Bobgy mentioned this pull request Jan 22, 2020
Closed
@mattnworb mattnworb deleted the fix-maybeDeleteOldestViewer-panic branch January 23, 2020 17:59
xiaogaozi added a commit to red-firefly/pipelines that referenced this pull request Feb 5, 2020
@xiaogaozi
Port kubeflow#2853: fix panic in Viewer cleanup
a99b3a9
@xiaogaozi xiaogaozi mentioned this pull request Feb 6, 2020
Merged
xiaogaozi added a commit to red-firefly/pipelines that referenced this pull request Feb 6, 2020
@xiaogaozi
Port kubeflow#2853: fix panic in Viewer cleanup (#2)
deed8a8
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@mattnworb @Jeffwan
fix panic in Viewer cleanup (kubeflow#2853)
1851334 
addresses issue kubeflow#2253. Passing `nil` as an argument to the varargs
`...DeleteOption` parameter of `client.Delete()` will panic since
client-go will iterate over the DeleteOption array and invoke each
(since DeleteOption is defined as
`type DeleteOptionFunc func(*DeleteOptions)`.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@skonto
Fixes for Integrating KServe with Openshift (kubeflow#2853)
ee0ff96 
* fixes for SM and OCP

Signed-off-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>

* updates

Signed-off-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>

* add pass through annotation support

Signed-off-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>

---------

Signed-off-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattnworb @k8s-ci-robot @IronPan @Ark-kun