Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update link of preload TFX sample #2839

Merged
merged 2 commits into from
Jan 16, 2020
Merged

[Doc] Update link of preload TFX sample #2839

merged 2 commits into from
Jan 16, 2020

Conversation

numerology
Copy link

@numerology numerology commented Jan 14, 2020 •
edited by jlewi
Loading

so that the user can open the ipynb file in JaaS notebook. Inspired by fastai

This change is Reviewable

@numerology
Copy link
Author

/assign @IronPan
/assign @rmgogogo
/cc @jessiezcc

jessiezcc
jessiezcc reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jessiezcc jessiezcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move "source code" link right after permission link? so that all links appear before the title.
do u think it would be better?

@numerology
Copy link
Author

Will do.

so that all links appear before the title.

Do you mean links appear before description? Thanks

@jessiezcc
Copy link
Contributor

yes

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 16, 2020

Thanks!
/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 16, 2020

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 16, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8e119e7 into kubeflow:master Jan 16, 2020
@numerology numerology deleted the link-to-jaas branch January 16, 2020 23:50
@numerology numerology mentioned this pull request Jan 17, 2020
Closed
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Jeffwan
[Doc] Update link of preload TFX sample (kubeflow#2839)
c668fcf 
* update link

* update tag in link and move
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@ReToCode @yuzisun
Add RBAC for inferencegraphs/finalizers (kubeflow#2839)
e6baf39 
* Add RBAC for inferencegraphs/finalizers

Signed-off-by: Reto Lehmann <retocode@icloud.com>

* Add finalizer to the chart

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Reto Lehmann <retocode@icloud.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessiezcc jessiezcc jessiezcc left review comments

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@Ark-kun Ark-kun

@IronPan IronPan

@rmgogogo rmgogogo

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@numerology @jessiezcc @Ark-kun @IronPan @k8s-ci-robot @rmgogogo