Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong example with container_op #2838

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix wrong example with container_op #2838

merged 1 commit into from
Jan 16, 2020

Conversation

kim-sardine
Copy link
Contributor

@kim-sardine kim-sardine commented Jan 14, 2020

Hi

I've fix some example codes.

when I ran latest dsl-compile with your current example code, I got error as below

Traceback (most recent call last):
  File "c:\programdata\miniconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\programdata\miniconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\ProgramData\Miniconda3\Scripts\dsl-compile.exe\__main__.py", line 7, in <module>
  File "c:\programdata\miniconda3\lib\site-packages\kfp\compiler\main.py", line 123, in main
    compile_pyfile(args.py, args.function, args.output, not args.disable_type_check)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\compiler\main.py", line 112, in compile_pyfile
    _compile_pipeline_function(pipeline_funcs, function_name, output_path, type_check)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\compiler\main.py", line 71, in _compile_pipeline_function
    kfp.compiler.Compiler().compile(pipeline_func, output_path, type_check)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\compiler\compiler.py", line 879, in compile
    package_path=package_path)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\compiler\compiler.py", line 941, in _create_and_write_workflow
    pipeline_conf)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\compiler\compiler.py", line 785, in _create_workflow
    pipeline_func(*args_list)
  File ".\pipeline.py", line 16, in pipeline
    .set_memory_limit('1GB')
  File "c:\programdata\miniconda3\lib\site-packages\kfp\dsl\_container_op.py", line 46, in _wrapped
    return func(*args, **kwargs)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\dsl\_container_op.py", line 1056, in _decorated
    ret = getattr(self._container, proxy_attr)(*args, **kwargs)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\dsl\_container_op.py", line 263, in set_memory_limit
    self._validate_memory_string(memory)
  File "c:\programdata\miniconda3\lib\site-packages\kfp\dsl\_container_op.py", line 179, in _validate_memory_string
    'Invalid memory string. Should be an integer, or integer followed '
ValueError: Invalid memory string. Should be an integer, or integer followed by one of "E|Ei|P|Pi|T|Ti|G|Gi|M|Mi|K|Ki"

so I've changed GB to G


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @kim-sardine. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numerology
Copy link

/ok-to-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 16, 2020

Thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-sardine
Copy link
Contributor Author

/retest

2 similar comments
@numerology
Copy link

/retest

@numerology
Copy link

/retest

@k8s-ci-robot k8s-ci-robot merged commit d353594 into kubeflow:master Jan 16, 2020
@kim-sardine kim-sardine deleted the patch-1 branch January 17, 2020 13:54
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants