Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] fix artifact handler query parameter key #2809

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 7, 2020

Error message when getting artifact:

Storage key is missing from artifact request

The bug was introduced in https://github.com/kubeflow/pipelines/pull/2745/files#diff-ac560cff381b58853d96359ba19782e9L179.
The query parameter should be "key", but it was renamed to "encodedKey".

/cc @eterna2

This PR depends on #2807.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

@Bobgy: GitHub didn't allow me to request PR reviews from the following users: eterna2.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Error message when getting artifact:

Storage key is missing from artifact request

The bug was introduced in #2745

/cc @eterna2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy Bobgy changed the title Ui fix artifact handler [UI] fix artifact handler query parameter key Jan 7, 2020
@Bobgy Bobgy self-assigned this Jan 7, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 7, 2020

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 7, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 8, 2020

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 7e19d7f into kubeflow:master Jan 8, 2020
@Bobgy Bobgy deleted the ui_fix_artifact_handler branch January 8, 2020 04:21
rui5i pushed a commit to rui5i/pipelines that referenced this pull request Jan 16, 2020
* Fix node server typing problems

* Fix artifact handler query name
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Fix node server typing problems

* Fix artifact handler query name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants