Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making json output format easier to read #2792

Merged
merged 7 commits into from
Jan 7, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jan 3, 2020

Modifying the diagnose_me output format for --json flag to make it easier to read.


This change is Reviewable

sdk/python/kfp/cli/diagnose_me_cli.py Outdated Show resolved Hide resolved
sdk/python/kfp/cli/diagnose_me_cli.py Show resolved Hide resolved
sdk/python/kfp/cli/diagnose_me_cli.py Outdated Show resolved Hide resolved
sdk/python/kfp/cli/diagnose_me_cli.py Outdated Show resolved Hide resolved
sdk/python/kfp/cli/diagnose_me_cli.py Outdated Show resolved Hide resolved
@gaoning777
Copy link
Contributor

/lgtm

@SinaChavoshi
Copy link
Contributor Author

/approved

@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Jan 7, 2020
@numerology
Copy link

/lgtm
/retest

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 4c580ba into kubeflow:master Jan 7, 2020
rui5i pushed a commit to rui5i/pipelines that referenced this pull request Jan 16, 2020
* Making json output format easier to read

* Update sdk/python/kfp/cli/diagnose_me_cli.py

good catch  :)

Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>

* update based on feedback

* Sample env validation pipeline with diagnose_me

* removing files that I accidentally added

* update based on review feedback

Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Making json output format easier to read

* Update sdk/python/kfp/cli/diagnose_me_cli.py

good catch  :)

Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>

* update based on feedback

* Sample env validation pipeline with diagnose_me

* removing files that I accidentally added

* update based on review feedback

Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants