[Component] Rollforward of PR#2697 #2760
Conversation
…mponents (kubeflow#2697)" This reverts commit 08ebd15
…n GCP components (kubeflow#2697)"" This reverts commit e9bdbd2
…ix-2697 � Conflicts: � components/gcp/container/component_sdk/python/kfp_component/launcher/__main__.py
|
/hold tests are still failing. |
|
/hold cancel |
|
/assign @gaoning777 |
|
/lgtm |
|
/retest |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Ok. It seems like the tests are pretty flaky. May need to investigate when we got some cycles. |
| if args.ui_metadata_path: | ||
| os.environ['KFP_UI_METADATA_PATH'] = args.ui_metadata_path | ||
|
|
||
| launch(args.file_or_module, [args.args, args.ui_metadata_path]) |
There was a problem hiding this comment.
Are you sure the args.ui_metadata_path needs to be passed to functions? They usually do no accept it.
There was a problem hiding this comment.
I've verified it works by building a new container image. But your point is good. The actual root cause might be simply the argument name should be ui_metadata_path but not --ui_metadata_path.
Let me take a shot to see if that works.
* Revert "Components - De-hardcoded the UI metadata file path in GCP components (kubeflow#2697)" This reverts commit 08ebd15 * Revert "Revert "Components - De-hardcoded the UI metadata file path in GCP components (kubeflow#2697)"" This reverts commit e9bdbd2 * provide a default ui json path * lint * test image * revert image tag * update * fix * update image tag * patch 2697 * fix test * fix
Rollforward of #2697
Provide a default value of mlpipeline ui metadata path.
This change is