Suggest run name based on the pipeline version used to create run #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingzhang36
changed the title
robustness: we arrive at newrun page with version id but no pipeline id
currently not used
Bobgy
reviewed
Dec 16, 2019
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-sample-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
1 similar comment
|
/test kubeflow-pipeline-sample-test |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…beflow#2731) * Suggest run name * refactor to combine similiar code block * Tests * format * Add handling for a case which we shouldn't run into now but just for robustness: we arrive at newrun page with version id but no pipeline id * Attach random number to suggested run name; remove a code block that is currently not used * format * address comments * format * refactor spy func * refactor random string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of optimization to save some clicks for our users when creating runs:
This change is