Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Add a notebook sample under parameterized_tfx_oss #2729

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

numerology
Copy link

@numerology numerology commented Dec 12, 2019

Better demonstrating the usage of RuntimeParameter.


This change is Reviewable

@numerology
Copy link
Author

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 17, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@numerology
Copy link
Author

/approve
Self-lgtmed since the change after review is minor.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3fa7556 into kubeflow:master Dec 18, 2019
@numerology numerology deleted the tfx-paramed-notebook-sample branch December 18, 2019 17:28
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…2729)

* add notebook sample

* Update

* remove my kfp endpoint.

* simplify import paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants