Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test cloudbuild yaml readability #2703

Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Dec 6, 2019

@Ark-kun
Improve readability by putting id as the first line

improves on #2673


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 6, 2019

/retest

2 similar comments
@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 6, 2019

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 10, 2019

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 10, 2019

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 11, 2019

Test failure is affected by #2708

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Bobgy Bobgy added the lgtm label Dec 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6b34df4 into kubeflow:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants