Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample test] Add parameterized_tfx_oss to 'normal' sample test corpus #2695

Merged
merged 22 commits into from
Dec 11, 2019

Conversation

numerology
Copy link

@numerology numerology commented Dec 3, 2019

Previously we maintain a precompiled .tar.gz package of the sample and test against that, which introduces several issues:

  1. Compatibility b/w TFX and KFP SDK is not tested here;
  2. Need a lot of special treatment in the sample test infra to skip compilation and so on;
  3. The versions of SDK and image used in this sample are tricky. Users might get confused. It's better to give users the opportunities to compile it on their own.

Provided that TFX 0.15.0 has been released (and stablized) for a while. I think it's reasonable to attempt to treat this one as other sample tests.


This change is Reviewable

@numerology
Copy link
Author

/cc @Bobgy I think the error you mentioned the other day is probably because, MLMD currently uses pipeline name as the unique id for each pipeline, as well as the runtime context associated with it. One implication of that is, if you make some change to the pipeline spec and submit it again under the same pipeline name, some schema checks might fail.

@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

@numerology
Copy link
Author

/retest

1 similar comment
@numerology
Copy link
Author

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Dec 4, 2019

/cc @Bobgy I think the error you mentioned the other day is probably because, MLMD currently uses pipeline name as the unique id for each pipeline, as well as the runtime context associated with it. One implication of that is, if you make some change to the pipeline spec and submit it again under the same pipeline name, some schema checks might fail.

Thanks! That makes sense. Sounds like this is something we should document to users too. It would be impossible to debug this issue for end users.

@numerology
Copy link
Author

/hold fixing the tests

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 6, 2019

if you make some change to the pipeline spec and submit it again under the same pipeline name, some schema checks might fail.

I wonder how this could happen.

MLMD has three typed objects - Context, Execution and Artifact. There is no entity that corresponds to "pipeline" (or "component").

@numerology
Copy link
Author

if you make some change to the pipeline spec and submit it again under the same pipeline name, some schema checks might fail.

I wonder how this could happen.

MLMD has three typed objects - Context, Execution and Artifact. There is no entity that corresponds to "pipeline" (or "component").

Good question. Execution is 'somewhat' a realization of component. See here for its def. Basically the ExecutionType under the same context cannot change, and ExecutionType contains input/output types and properties. Then, virtually one cannot change component interface without changing pipeline name.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Dec 6, 2019
@numerology
Copy link
Author

/hold cancel
Tests are passing.

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 10, 2019

/lgtm

@numerology
Copy link
Author

/approve

Thanks!

@numerology
Copy link
Author

/assign @IronPan

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 10, 2019

@numerology If you had any issues debugging the failures during this PR preparation, you can create issues tracking them.

@numerology
Copy link
Author

@numerology If you had any issues debugging the failures during this PR preparation, you can create issues tracking them.

I'll say mostly it's because I'm not familiar with the logic of initialization test...However the lack of log/feedback contributes to the mess as well. Will think about how to improve this. Thanks.

@IronPan
Copy link
Member

IronPan commented Dec 10, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ef381aa into kubeflow:master Dec 11, 2019
@numerology numerology deleted the fix-parameterized-tfx-oss branch December 11, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants