-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample test] Add parameterized_tfx_oss to 'normal' sample test corpus #2695
[Sample test] Add parameterized_tfx_oss to 'normal' sample test corpus #2695
Conversation
/cc @Bobgy I think the error you mentioned the other day is probably because, MLMD currently uses pipeline name as the unique id for each pipeline, as well as the runtime context associated with it. One implication of that is, if you make some change to the pipeline spec and submit it again under the same pipeline name, some schema checks might fail. |
/test kubeflow-pipeline-e2e-test |
/retest |
1 similar comment
/retest |
Thanks! That makes sense. Sounds like this is something we should document to users too. It would be impossible to debug this issue for end users. |
4e93e56
to
7d3060f
Compare
/hold fixing the tests |
I wonder how this could happen. MLMD has three typed objects - Context, Execution and Artifact. There is no entity that corresponds to "pipeline" (or "component"). |
Good question. Execution is 'somewhat' a realization of component. See here for its def. Basically the ExecutionType under the same context cannot change, and ExecutionType contains input/output types and properties. Then, virtually one cannot change component interface without changing pipeline name. |
…fix-parameterized-tfx-oss
/hold cancel |
/lgtm |
/approve Thanks! |
/assign @IronPan |
@numerology If you had any issues debugging the failures during this PR preparation, you can create issues tracking them. |
I'll say mostly it's because I'm not familiar with the logic of initialization test...However the lack of log/feedback contributes to the mess as well. Will think about how to improve this. Thanks. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously we maintain a precompiled
.tar.gz
package of the sample and test against that, which introduces several issues:Provided that TFX 0.15.0 has been released (and stablized) for a while. I think it's reasonable to attempt to treat this one as other sample tests.
This change is