SDK - Unified the function signature parsing implementations #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now only changes the case of the first letter.
numerology
reviewed
Dec 5, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…w#2689) * Replaced `_instance_to_dict(obj)` with `obj.to_dict()` * Fixed the capitalization in _python_function_name_to_component_name It now only changes the case of the first letter. * Replaced the _extract_component_metadata function with _extract_component_interface * Stopped adding newline to the component description. * Handling None inputs and outputs * Not including emply inputs and outputs in component spec * Renamed the private attributes that the @pipeline decorator sets * Changged _extract_pipeline_metadata to use _extract_component_interface * Fixed issues based on feedback
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…flow#2689) * Bump github.com/emicklei/go-restful Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible. - [Release notes](https://github.com/emicklei/go-restful/releases) - [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md) - [Commits](emicklei/go-restful@v2.9.5...v2.16.0) --- updated-dependencies: - dependency-name: github.com/emicklei/go-restful dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Update requirements.txt Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update xgb.Dockerfile Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The SDK had were three different code paths that that parsed the python function signatures:
_extract_component_interfacewhich was used byfunc_to_container_op_extract_pipeline_metadatawhich was used by the DSL compiler during the compilation_extract_component_metadatawhich was used by the@componentdecoratorThe parsing code was pretty similar, but also had inconsistencies. This leads to problems (for example when the pipeline parameter types were parsed differently from the component input types).
This PR unifies the signature parsing code paths.
This is mostly a refactoring, so it does not introduce any changes for the SDK user (apart from fixing the inconsistency bugs).
Closes #2533
This change is