Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job link -> run link #268

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Job link -> run link #268

merged 1 commit into from
Nov 17, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 15, 2018

Fixes #266.

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 358

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.993%

Totals Coverage Status
Change from base Build 340: 0.0%
Covered Lines: 1704
Relevant Lines: 2192

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 350

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.993%

Totals Coverage Status
Change from base Build 340: 0.0%
Covered Lines: 1704
Relevant Lines: 2192

💛 - Coveralls

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f2e9a3 into master Nov 17, 2018
@yebrahim yebrahim deleted the yebrahim/patch-2 branch November 22, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants