support extra parameters for mysql connection #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @jingzhang36 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
|
/lgtm |
xaniasd
force-pushed
the
mysql-extra-params
branch
from
f79c068
to
f52b3e5
Compare
|
/retest |
xaniasd
force-pushed
the
mysql-extra-params
branch
from
63c05d3
to
493ea33
Compare
xaniasd
force-pushed
the
mysql-extra-params
branch
from
493ea33
to
0fd2210
Compare
|
@IronPan can we merge this one please? I'm tired of resolving merge conflicts 😄 |
|
/lgtm |
|
/test kubeflow-pipeline-sample-test |
1 similar comment
|
/test kubeflow-pipeline-sample-test |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* support extra parameters for mysql connection * added missing const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow flexible configuration of the client connection for mysql, by providing an extra object in the JSON configuration. For instance:
{ "DBConfig": { "DriverName": "mysql", "DBName": "test", "ExtraParams": { "tls": "true"} } }This could replace the GroupConcatMaxLen parameter defined now as well.
This change is