Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorize create run requests #2663

Merged
merged 71 commits into from
Dec 11, 2019
Merged

Authorize create run requests #2663

merged 71 commits into from
Dec 11, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 26, 2019 •
edited
Loading

This change is Reviewable

This PR includes the changes in #2657.
We can first merge the other one before reviewing this.

@nrchakradhar nrchakradhar mentioned this pull request Nov 29, 2019
Closed
@gaoning777 gaoning777 changed the title [WIP] Authorize create run requests Authorize create run requests Dec 2, 2019
IronPan
IronPan reviewed Dec 9, 2019
View reviewed changes
backend/src/apiserver/resource/client_manager_fake.go Outdated Show resolved Hide resolved
backend/src/apiserver/server/test_util.go Outdated Show resolved Hide resolved
backend/src/apiserver/server/run_server.go Show resolved Hide resolved
backend/src/apiserver/server/util.go Outdated Show resolved Hide resolved
@gaoning777
Copy link
Contributor Author

/retest

IronPan
IronPan reviewed Dec 10, 2019
View reviewed changes
backend/src/apiserver/server/util.go Outdated Show resolved Hide resolved
backend/src/apiserver/server/util.go Outdated Show resolved Hide resolved
backend/src/apiserver/server/run_server.go Outdated Show resolved Hide resolved
@IronPan
Copy link
Member

IronPan commented Dec 10, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e697ace into kubeflow:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

@Bobgy Bobgy

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaoning777 @nrchakradhar @IronPan @k8s-ci-robot @Bobgy