Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Git clone #2658

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Components - Git clone #2658

merged 1 commit into from
Nov 27, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 26, 2019 •
edited by jlewi
Loading

This change is Reviewable

numerology
numerology reviewed Nov 26, 2019
View reviewed changes
components/git/clone/component.yaml
command:
- git
- clone
- --depth=1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we consider making depth an input parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that.
The idea is to export the data, rather than creating a full clone. (Maybe I need to rename the component.)
Even the .git subdirectory should probably be deleted.
WDYT?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't have a strong opinion. Either way looks fine. What's the example use case of this component?

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aaf5785 into kubeflow:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology left review comments

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@numerology numerology

Labels
approved area/components lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ark-kun @numerology @k8s-ci-robot