Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Get kubeflow namespace from kfp UI #2655

Merged
merged 4 commits into from
Nov 28, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 26, 2019

Needed for kubeflow multi user support
/cc @gaoning777


This change is Reviewable

@gaoning777 gaoning777 self-assigned this Nov 27, 2019
@gaoning777
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 28, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 675b1cd into kubeflow:master Nov 28, 2019
@Bobgy Bobgy deleted the ui_namespace_from_kf branch December 5, 2019 00:59
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ubeflow#2655)

* Added v2 support and e2e test cases for pmml, sklearn, paddle, lgb and xgb.

Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>

* Added v2 grpc support for lightgbm model

Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>

* Added v2 grpc support for paddle server

Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>

* v2 endpoint, grpc e2e tests code cleanup

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* debug: moved sklearn, autoscalling e2e to test_slow group

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* lgbserver model issue fixes and enabled e2e tests

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* upgraded fastapi version to v0.89.1

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* kserve unit test issue fix

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* updated grpc e2e tests

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* Added review changes

Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>

* lint issue fix

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* Add pmml output fields

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Convert pmml to multi outputs

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix pmml test output expectation

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add lightgbm tests

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* fix pmml test expectation

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants