Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace to the resourcereference #2651

Merged
merged 15 commits into from
Dec 4, 2019
Merged

add namespace to the resourcereference #2651

merged 15 commits into from
Dec 4, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 26, 2019 •
edited by abhi-g
Loading

This change is Reviewable

Ark-kun
Ark-kun reviewed Nov 26, 2019
View reviewed changes
backend/api/run.proto Outdated
@@ -188,6 +191,7 @@ message UnarchiveRunRequest {

message DeleteRunRequest {
string id = 1;
string namespace = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the run can be uniquely identified by the run ID, so the namespace might be unnecessary. Same with other API methods that work on existing runs.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 26, 2019

Is "namespace" the only user isolation implementation we have in mind for the future?
Should we use something generic like "user" or "isolation_group" in the API surface?

@gaoning777 gaoning777 changed the title add namespace to some run APIs add namespace to the resourcereference Nov 26, 2019
@gaoning777 gaoning777 mentioned this pull request Nov 26, 2019
Closed
@gaoning777 gaoning777 mentioned this pull request Nov 26, 2019
Merged
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@Bobgy Bobgy mentioned this pull request Nov 28, 2019
Merged
1 task
Bobgy
Bobgy reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

backend/src/apiserver/resource/model_converter.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 2, 2019
@gaoning777 gaoning777 mentioned this pull request Dec 2, 2019
Closed
@Bobgy
Copy link
Contributor

Bobgy commented Dec 3, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Dec 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1b85a61 into kubeflow:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@IronPan IronPan IronPan left review comments

@Ark-kun Ark-kun Ark-kun left review comments

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

@Bobgy Bobgy

@jingzhang36 jingzhang36

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaoning777 @Ark-kun @Bobgy @IronPan @k8s-ci-robot @jingzhang36