Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api resource type conversion needs to convert pipeline version type #2648

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Nov 25, 2019

Api resource type conversion needs to convert pipeline version type, since now pipeline version shows as a type of resource reference in run


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Nov 25, 2019

/lgtm

@jingzhang36
Copy link
Contributor Author

/approve low risk change, so check in by myself

@IronPan
Copy link
Member

IronPan commented Nov 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan merged commit df41f3f into kubeflow:master Nov 25, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants