Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend - Add support for Minio artifact URIs #2645

Merged
merged 5 commits into from
Nov 28, 2019
Merged

Frontend - Add support for Minio artifact URIs #2645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3964f4b
Frontend - Add support for Minio artifact URIs
Ark-kun Nov 23, 2019
de02add
Fixed style
Ark-kun Nov 25, 2019
aa86b65
Removed unused variable
Ark-kun Nov 26, 2019
24cb4d2
Old Node does not support named capture groups in regexes
Ark-kun Nov 27, 2019
2ab2127
Made the URL relative
Ark-kun Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed style
  • Loading branch information
@Ark-kun
Ark-kun committed Nov 25, 2019
commit de02add667d8b969fb4bbbbb406970a072286766
2 changes: 1 addition & 1 deletion frontend/src/components/ArtifactLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const ArtifactLink: React.FC<{ artifactUri?: string }> = ({ artifactUri }
} else if (artifactUri.startsWith('minio:')) {
clickableUrl = generateMinioArtifactUrl(artifactUri);
}
}
}

if (clickableUrl) {
// Opens in new window safely
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/Utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ export function generateMinioArtifactUrl(minioUri: string): string | undefined {
if (!minioUri.startsWith(MINIO_URI_PREFIX)) {
return undefined;
}

const matches = minioUri.match(/^minio:\/\/(?<bucket>[^\/]+)\/(?<key>.+)$/);
if (matches == null) {
return undefined;
Expand Down