Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button styling for new experiment and new run #264

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Nov 14, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 14, 2018

Pull Request Test Coverage Report for Build 363

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+10.6%) to 78.17%

Files with Coverage Reduction New Missed Lines %
src/lib/Utils.ts 1 90.16%
src/pages/NewRun.tsx 1 96.37%
src/pages/PipelineSelector.tsx 5 56.1%
src/pages/ExperimentDetails.tsx 30 14.13%
src/pages/PipelineDetails.tsx 44 11.11%
Totals Coverage Status
Change from base Build 329: 10.6%
Covered Lines: 1775
Relevant Lines: 2193

💛 - Coveralls

@rileyjbauer
Copy link
Contributor Author

/retest

@rileyjbauer
Copy link
Contributor Author

/test presubmit-e2e-test

@@ -155,7 +156,8 @@ class Toolbar extends React.Component<ToolbarProps> {
<div>{/* Extra level needed by tooltip when child is disabled */}
<BusyButton id={b.id} color='secondary' onClick={b.action} disabled={b.disabled}
title={b.title} icon={b.icon} busy={b.busy || false}
outlined={b.outlined || false} />
outlined={(b.outlined && !b.primary) || false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the || false needed here?

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a807ad3 into master Nov 19, 2018
@IronPan IronPan deleted the button-styling branch June 28, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants