-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update button styling for new experiment and new run #264
Conversation
Pull Request Test Coverage Report for Build 363
💛 - Coveralls |
/retest |
/test presubmit-e2e-test |
@@ -155,7 +156,8 @@ class Toolbar extends React.Component<ToolbarProps> { | |||
<div>{/* Extra level needed by tooltip when child is disabled */} | |||
<BusyButton id={b.id} color='secondary' onClick={b.action} disabled={b.disabled} | |||
title={b.title} icon={b.icon} busy={b.busy || false} | |||
outlined={b.outlined || false} /> | |||
outlined={(b.outlined && !b.primary) || false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the || false
needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is