Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Python support for arbitrary secret, similar to ".use_gcp_secret('user-gcp-sa')" #2639

Merged
merged 16 commits into from
Dec 3, 2019

Conversation

NikeNano
Copy link
Member

@NikeNano NikeNano commented Nov 21, 2019

Hi,

This PR is related to how to add secrets to Kubeflow containers operations in the python SDK. There are functionality for adding the GCP secrets but often other secrets needs to be added as well.

I believe this would be useful for others and therefore made this PR :)

Happy for feedback!


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @NikeNano. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NikeNano NikeNano changed the title Secrets support SDK - Python support for arbitrary secret, similar to ".use_gcp_secret('user-gcp-sa')" Nov 21, 2019
@numerology
Copy link

Thanks @NikeNano !
/ok-to-test

sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/tests/dsl/utils_tests.py Outdated Show resolved Hide resolved
sdk/python/tests/dsl/utils_tests.py Outdated Show resolved Hide resolved
sdk/python/tests/dsl/utils_tests.py Outdated Show resolved Hide resolved
sdk/python/tests/dsl/utils_tests.py Outdated Show resolved Hide resolved
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
sdk/python/tests/dsl/utils_tests.py Outdated Show resolved Hide resolved
sdk/python/tests/dsl/utils_tests.py Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 26, 2019
@numerology
Copy link

/lgtm
Thanks @NikeNano

sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 27, 2019
sdk/python/kfp/utils.py Outdated Show resolved Hide resolved
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 2, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 2, 2019

Last request:
Can you please move sdk/python/kfp/utils.py to sdk/python/kfp/dsl/extensions/kubernetes.py
We'll probably move other extensions there at some point (gcp, aws, azure, onprem).

@NikeNano
Copy link
Member Author

NikeNano commented Dec 3, 2019

Last request:
Can you please move sdk/python/kfp/utils.py to sdk/python/kfp/dsl/extensions/kubernetes.py
We'll probably move other extensions there at some point (gcp, aws, azure, onprem).

Sure will do! Happy to later make a new PR and move the other files as well if "at some point" is not in the distant future :)

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 3, 2019
@NikeNano
Copy link
Member Author

NikeNano commented Dec 3, 2019

/retest

@NikeNano
Copy link
Member Author

NikeNano commented Dec 3, 2019

Import error, fixing it :). Will update when i have fixed it.

@NikeNano
Copy link
Member Author

NikeNano commented Dec 3, 2019

Import error, fixing it :). Will update when i have fixed it.

Believe it should be fixed now. Had to also update the build file. I will check the tests later.

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 3, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants