Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move frontend unit tests to prow #2637

Merged
merged 6 commits into from
Nov 25, 2019
Merged

Move frontend unit tests to prow #2637

merged 6 commits into from
Nov 25, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 21, 2019 •
edited
Loading

Note, test configuration in prow lives in kubernetes/test-infra#15358
Update, this is ready for review and merge.

This is part of #1653

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 21, 2019

/test kubeflow-pipeline-frontend-test

@Bobgy Bobgy changed the title [Frontend] Skip coveralls in CI [WIP] [Frontend] Skip coveralls in CI Nov 21, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 22, 2019

/test kubeflow-pipeline-frontend-test

@Bobgy Bobgy changed the title [WIP] [Frontend] Skip coveralls in CI [WIP] Move frontend unit tests to prow Nov 22, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 25, 2019

/test kubeflow-pipeline-frontend-test

@Bobgy Bobgy changed the title [WIP] Move frontend unit tests to prow Move frontend unit tests to prow Nov 25, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 25, 2019

/assign @IronPan

@Bobgy Bobgy mentioned this pull request Nov 25, 2019
Closed
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 25, 2019

/priority p0

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 25, 2019

/test kubeflow-pipeline-frontend-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 25, 2019

/test kubeflow-pipeline-frontend-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor

/lgtm

@Bobgy Bobgy mentioned this pull request Nov 25, 2019
Merged
@jingzhang36
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b271c48 into master Nov 25, 2019
@Bobgy Bobgy deleted the Bobgy-patch-2 branch November 26, 2019 00:05
@Bobgy Bobgy mentioned this pull request Nov 26, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

@rmgogogo rmgogogo

@jingzhang36 jingzhang36

Labels
approved area/frontend area/testing lgtm priority/p0 size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bobgy @k8s-ci-robot @rmgogogo @jingzhang36 @IronPan