Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open version api in BE proto and auto-generate BE/FE api methods #2620

Merged
merged 6 commits into from
Nov 27, 2019

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Nov 18, 2019

Open version api in BE proto and auto-generate BE/FE api methods. The auto-generated FE api is needed for later FE change at jingzhang36#2


This change is Reviewable

@jingzhang36 jingzhang36 changed the title For later FE PR, open version api in BE proto and auto-generate BE/FE api methods Open version api in BE proto and auto-generate BE/FE api methods Nov 18, 2019
@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Nov 25, 2019

/lgtm
/approve

@jingzhang36
Copy link
Contributor Author

/hold cancel

@jingzhang36
Copy link
Contributor Author

/approve

@Bobgy Bobgy removed the lgtm label Nov 26, 2019
@Bobgy
Copy link
Contributor

Bobgy commented Nov 26, 2019

/lgtm

@jingzhang36
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjwagner
Copy link
Member

Comment to bump the tide status.

@cjwagner
Copy link
Member

/test kubeflow-pipeline-frontend-test

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants