Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing kfp.cli.diagnose_me package to setup.py Fixes #2609 #2610

Conversation

stephenhenderson
Copy link
Contributor

@stephenhenderson stephenhenderson commented Nov 14, 2019

The kfp.cli.diagnose_me package was missing from the setup.py packages list and so wasn't included in the latest release pushed to pypi.org.

This package is required to run the kfp CLI - it raises a "Module Not Found" exception if not present
Fixes #2609


This change is Reviewable

The kfp.cli.diagnose_me package was missing from the setup.py packages list and so wasn't included in the latest release pushed to pypi.org.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @stephenhenderson. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stephenhenderson
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@stephenhenderson
Copy link
Contributor Author

/assign @hongye-sun

@numerology
Copy link

/assign @SinaChavoshi

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 14, 2019

Thanks for fixing this!
/lgtm
/approve

@hongye-sun Looks like we do not run tests for the CLI.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stephenhenderson
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@stephenhenderson: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c66120b into kubeflow:master Nov 15, 2019
@SinaChavoshi
Copy link
Contributor

Nice catch !!! Thank you for finding / fixing this :)

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Pan Li <panli889@gmail.com>

Signed-off-by: Pan Li <panli889@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kfp 0.1.35 tar.gz in pypi.org is missing diagnose_me directory
7 participants