Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete namespaced-install.yaml #2603

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Delete namespaced-install.yaml #2603

merged 1 commit into from
Jan 7, 2020

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 13, 2019 •
edited by jlewi
Loading

This file is no longer needed as we store the materialized version in GCS
/assign @Bobgy

This change is Reviewable

@IronPan
Delete namespaced-install.yaml
44c9ea8 
This file is no longer needed as we store the materialized version in GCS
@Bobgy
Copy link
Contributor

Bobgy commented Nov 25, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Dec 16, 2019

/test kubeflow-pipeline-frontend-test

@IronPan
Copy link
Member Author

IronPan commented Dec 16, 2019

/test kubeflow-pipeline-e2e-test

4 similar comments
@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

/test kubeflow-pipeline-e2e-test

@Bobgy Bobgy mentioned this pull request Jan 7, 2020
Merged
@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

/retest

1 similar comment
@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2873420 into master Jan 7, 2020
@numerology
Copy link

@IronPan Quick Q: is publishing the materialized version to GCS part of the oncall process?

@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2020

@IronPan Quick Q: is publishing the materialized version to GCS part of the oncall process?

It is part of release.cloudbuild.yaml, no manual action needed

@Bobgy Bobgy deleted the IronPan-patch-9 branch January 10, 2020 04:17
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@IronPan @Jeffwan
Delete namespaced-install.yaml (kubeflow#2603)
cda2566 
This file is no longer needed as we store the materialized version in GCS
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update knative serving go dependency (kubeflow#2603)
898005e 
* Update knative serving go dependency

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* wait for webhook

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuromage neuromage Awaiting requested review from neuromage

@paveldournov paveldournov Awaiting requested review from paveldournov

Assignees

@Bobgy Bobgy

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IronPan @Bobgy @k8s-ci-robot @numerology