Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] default yaml.dump to block style #2591

Merged
merged 3 commits into from
Nov 19, 2019
Merged

[fix] default yaml.dump to block style #2591

merged 3 commits into from
Nov 19, 2019

Conversation

l1990790120
Copy link
Contributor

@l1990790120 l1990790120 commented Nov 11, 2019

As issue raised in #2495

The output from yaml.dump does not work well with golang's backend causing the pipeline to return 500 when triggered due to yaml parsing error

Maybe it's better to detect when the string is too long and apply block style accordingly than applying for every field, that's up to the maintainer, but this fixes the 500 as well.


This change is Reviewable

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @l1990790120. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@l1990790120
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2019

/ok-to-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2019

/retest

@l1990790120
Copy link
Contributor Author

@Ark-kun
I changed it to pipe.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 19, 2019

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 19, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07296bc into kubeflow:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants