Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Minor fix to MKP secret setup guide #2576

Merged
merged 3 commits into from
Nov 9, 2019

Conversation

numerology
Copy link

@numerology numerology commented Nov 8, 2019

Change the way of specifying namespace.

Sometimes --current option might not work for gcloud in MacOS, causing empty secret and permission issues.


This change is Reviewable

@numerology
Copy link
Author

/assign @rmgogogo
/assign @Bobgy

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I totally agree with this.

left a minor concern

manifests/gcp_marketplace/guide.md Outdated Show resolved Hide resolved
@rmgogogo
Copy link
Contributor

rmgogogo commented Nov 8, 2019

Thanks, give hours to do more test on it.
I find something wrong in my existing cluster, wondering whether we have other issue. (not sure whether you tested the new CLI)

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 8, 2019
@numerology
Copy link
Author

Thanks, give hours to do more test on it.
I find something wrong in my existing cluster, wondering whether we have other issue. (not sure whether you tested the new CLI)

What's the symptom? I did not try out the new cli.

@rmgogogo
Copy link
Contributor

rmgogogo commented Nov 8, 2019

tested and all works well.

/lgtm

@Bobgy
Copy link
Contributor

Bobgy commented Nov 8, 2019

@IronPan for approval
@rmgogogo Can you approve?

@IronPan
Copy link
Member

IronPan commented Nov 8, 2019

/approve

@IronPan
Copy link
Member

IronPan commented Nov 8, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

k8s robot seems stop working, manually merged

@numerology numerology merged commit 9f258a8 into kubeflow:master Nov 9, 2019
@numerology numerology deleted the fix-mkp-doc branch November 9, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants