-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes test flakiness caused by "unsupported operand type(s) for -=: 'Retry' and 'int'" #2563
Conversation
…Retry' and 'int'"
Thanks @Bobgy ! This might need some time to run, though... |
@numerology np, I will retry a few time today to verify. |
/lgtm |
Thanks for fixing the issue! |
First try succeeded |
/test kubeflow-pipeline-e2e-test |
Second try succeeded |
Third try succeeded |
Fourth try succeeded |
Fifth try succeeded |
Sixth try failed with
Not related to this fix, but it shouldn't happen. Because image building should be cached. It seems inverse-proxy-agent is wrongly queried even though it is not built. UPDATE: fixed the inverse proxy image issue in #2566 /test kubeflow-pipeline-e2e-test |
Seventh try succeeded. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ow#2563) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
I want to first test if this fix actually help.
part of #2556
The fix come from https://stackoverflow.com/a/37531821
/kind bug
This change is