Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test flakiness caused by "unsupported operand type(s) for -=: 'Retry' and 'int'" #2563

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 7, 2019

I want to first test if this fix actually help.
part of #2556
The fix come from https://stackoverflow.com/a/37531821

/kind bug


This change is Reviewable

@Bobgy Bobgy changed the title Fixes test flakiness caused by "unsupported operand type(s) for -=: 'Retry' and 'int'" [WIP] Fixes test flakiness caused by "unsupported operand type(s) for -=: 'Retry' and 'int'" Nov 7, 2019
@numerology
Copy link

Thanks @Bobgy ! This might need some time to run, though...

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

@numerology np, I will retry a few time today to verify.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 7, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 7, 2019

Thanks for fixing the issue!

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

First try succeeded
/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Second try succeeded
/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Third try succeeded
/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Fourth try succeeded
/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Fifth try succeeded
/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Sixth try failed with

Step #0: go: error loading module requirements
Step #0: The command '/bin/sh -c GO111MODULE=on go build -o /bin/persistence_agent backend/src/agent/persistence/*.go' returned a non-zero code: 1

Not related to this fix, but it shouldn't happen. Because image building should be cached. It seems inverse-proxy-agent is wrongly queried even though it is not built.

UPDATE: fixed the inverse proxy image issue in #2566

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Seventh try succeeded.
I think we can merge and later take an eye on if this error shows up again.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title [WIP] Fixes test flakiness caused by "unsupported operand type(s) for -=: 'Retry' and 'int'" Fixes test flakiness caused by "unsupported operand type(s) for -=: 'Retry' and 'int'" Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 24c94d7 into master Nov 7, 2019
@Bobgy Bobgy deleted the Bobgy-patch-3 branch November 7, 2019 07:24
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ow#2563)

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants