-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix slow query when get runs #2559
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @wstian. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
this commit fixes #2071 |
/ok-to-test |
/assign @jingzhang36 |
Thanks @wstian! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wstian could you double check the CLA? Thanks! |
@googlebot I signed it! |
@googlebot I signed it! i think it should be OK now. I have signed the CLA with the commit email |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR seems to be stuck in prow bot's merge pool. Although it shouldn't get merged yet. One test is failing. |
/lgtm |
/test |
/lgtm |
/test kubeflow-pipeline-e2e-test |
* Adding doc for release process v2 Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Adding doc for release process v2 Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Updating for new cadence Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Updating for new cadence Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Added instructions for release day Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Updating release docs Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Updating release docs Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> * Updating release docs Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com> --------- Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com>
the current sql for runs list as below:
the union index as below:
the left join query as below, the union index doesn't work
change the left join as below:
the result as below:
This change is