Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more notebook license issues #2552

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 6, 2019

This is blocking this week's release.

follows up on #2546

/kind bug
/assign @jingzhang36


This change is Reviewable

@hongye-sun
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingzhang36
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit d6d9d8d into kubeflow:master Nov 6, 2019
@Bobgy Bobgy deleted the fix_notebook_license_2 branch November 6, 2019 05:27
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Separate kserve crd into separate chart

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Rename charts

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix enableMetricAggregation variable value type

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update issue template

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants