[Frontend] Fix run id not populated in NewRun page when clicked too fast bug #2547
Conversation
|
/test kubeflow-pipeline-e2e-test |
| ? this.state.pipeline.id! | ||
| : pipelineIdFromParams | ||
| ? pipelineIdFromParams | ||
| : ''; |
There was a problem hiding this comment.
try to learn TS from you.
do it equal to following? not sure whether should use ()
this.state.pipeline
? this.state.pipeline.id!
: (pipelineIdFromParams
? pipelineIdFromParams
: '')
There was a problem hiding this comment.
Yes, it's equal.
I agree your format looks clearer to me too.
But we are using prettier for auto formatting, it doesn't allow any format change.
Main opinion of prettier
No need to discuss style in code review
https://prettier.io/docs/en/option-philosophy.html
And corresponding issue: prettier/prettier#3805
for context.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Sukumar Gaonkar <sgaonkar4@bloomberg.net> Signed-off-by: Sukumar Gaonkar <sgaonkar4@bloomberg.net>
Fixes #2488
Before, when page is not loaded yet, clicking "Create Run" will go to a page that doesn't specify which pipeline to run.
After, screencast: https://drive.google.com/file/d/1QiGCwdKByWsu-AvsTaTIn6_D8CgwEd9j/view
/area front-end
/kind bug
/cc @Ark-kun
/assign @rmgogogo
This change is