Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - Added support for https artifact links #2517

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 31, 2019

Currently the Artifacts list makes artifact URLs clickable only when they are 'gs://'.
This commit adds support for https: links.

This change is Reviewable

@Ark-kun Ark-kun requested a review from Bobgy October 31, 2019 03:55
@Ark-kun Ark-kun changed the title Added support for https artifact links Frontend - Added support for https artifact links Oct 31, 2019
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the try! It's a good start. : )

Some nitpickings only.

frontend/src/components/GcsLink.tsx Outdated Show resolved Hide resolved
frontend/src/components/GcsLink.tsx Outdated Show resolved Hide resolved
frontend/src/components/GcsLink.tsx Outdated Show resolved Hide resolved
@Bobgy
Copy link
Contributor

Bobgy commented Oct 31, 2019

You need to take a look at Travis failure too. Some formatting warnings there.

Follow guide https://github.com/kubeflow/pipelines/tree/master/frontend#code-style for setting up automatic formatting in IDE. Or run a command to format.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 31, 2019

You need to take a look at Travis failure too. Some formatting warnings there.

Follow guide https://github.com/kubeflow/pipelines/tree/master/frontend#code-style for setting up automatic formatting in IDE. Or run a command to format.

Done. Thanks.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 31, 2019

I've decided to rename GcsLink to ArtifactLink since it's no longer GCS-only.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 1, 2019

@Ark-kun Thanks, this looks great!

I didn't add unit tests initially, so let's skip them this time. The changes are simple enough.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Nov 1, 2019

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 1, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 499e24b into master Nov 1, 2019
@Ark-kun Ark-kun deleted the Frontend---Added-support-for-https-artifact-links branch November 1, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants