Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate api since https://github.com/kubeflow/pipelines/pull/2445 changed api proto #2506

Merged
merged 3 commits into from
Oct 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 133 additions & 90 deletions backend/api/go_client/pipeline.pb.go

Large diffs are not rendered by default.

65 changes: 34 additions & 31 deletions backend/api/go_client/resource_reference.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion backend/api/go_http_client/job_model/api_resource_type.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions backend/api/go_http_client/pipeline_model/api_pipeline.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion backend/api/go_http_client/run_model/api_resource_type.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions backend/api/swagger/job.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions backend/api/swagger/kfp_api_single_file.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion backend/api/swagger/pipeline.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions backend/api/swagger/run.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions backend/test/integration/pipeline_api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,19 @@ func verifyPipeline(t *testing.T, pipeline *model.APIPipeline) {
{Name: "param1", Value: "hello"}, // Default value in the pipeline template
{Name: "param2"}, // No default value in the pipeline
},
// TODO(jingzhang36): after version API launch, remove the following field.
// This is because after the version API launch, we won't have defautl
// version produced automatically when creating pipeline.
DefaultVersion: &model.APIPipelineVersion{
CreatedAt: pipeline.CreatedAt,
ID: pipeline.ID,
Name: "arguments-parameters.yaml",
Parameters: []*model.APIParameter{
{Name: "param1", Value: "hello"},
{Name: "param2"}},
ResourceReferences: []*model.APIResourceReference{{
Key: &model.APIResourceKey{ID: pipeline.ID, Type: model.APIResourceTypePIPELINE},
Relationship: model.APIRelationshipOWNER}}},
}
assert.Equal(t, expected, *pipeline)
}
Expand Down