Set DB GroupConcatMaxLen config to default of 4MB #2497

krajasek · 2019-10-25T21:58:19Z

Fix for KFP issue: #2310

This change is

googlebot · 2019-10-25T21:58:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

k8s-ci-robot · 2019-10-25T21:58:33Z

Hi @krajasek. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

krajasek · 2019-11-01T20:22:39Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

krajasek · 2019-11-04T22:33:42Z

@IronPan -My company (Ciitizen) signed an initial CLA and later signed a new CLA with a google group that had my details as contributor. However, I do not seem to get past this CLA check on this PR. How do we resolve this CLA issue now? Our legal team has sent followup emails to cla-submissions@google.com but have not yet received any response. Any help here is much appreciated. Thanks.

krajasek · 2019-11-05T21:43:37Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

googlebot · 2019-11-05T21:43:40Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Ark-kun · 2019-11-05T21:48:55Z

Thank you for finding and fixing this issue!

P.S. Is there any way to make the backend fail hard when those limits are exceeded? These issues are really hard to debug, so it would be great if the query will just fail with "... size limit exceeded" message.

/ok-to-test

Ark-kun · 2019-11-05T21:49:31Z

backend/src/apiserver/client/sql.go

 	return &mysql.Config{
 		User:                 user,
 		Passwd:               password,
 		Net:                  "tcp",
 		Addr:                 fmt.Sprintf("%s:%s", mysqlServiceHost, mysqlServicePort),
-		Params:               map[string]string{"charset": "utf8", "parseTime": "True", "loc": "Local"},
+		Params:               map[string]string{
+									"charset": "utf8",


Nit: Formatting seems strange here.

Ark-kun · 2019-11-05T21:49:47Z

/lgtm

Ark-kun · 2019-11-06T00:56:38Z

/retest

krajasek · 2019-11-06T02:14:31Z

Thank you for finding and fixing this issue!

P.S. Is there any way to make the backend fail hard when those limits are exceeded? These issues are really hard to debug, so it would be great if the query will just fail with "... size limit exceeded" message.

/ok-to-test

@Ark-kun - Thanks for the review. To my knowledge, MySQL group_concat method returns silently with truncated text when the limit is exceeded. An alternative way to sidestep this issue would be to abandon the usage of group_concat and look at rewriting the logic that gathers metrics.

Ark-kun · 2019-11-06T21:58:15Z

@IronPan Can you please approve this PR?

IronPan · 2019-11-07T21:20:21Z

/approve
Thank you for the fix!

k8s-ci-robot · 2019-11-07T21:20:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~backend/OWNERS~~ [IronPan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…#989) Some time ago [this](kubeflow/pipelines#2310) issue has been reported on pipelines relating a problem in which metrics were not being properly loaded. The problem has been fixed by kubeflow/pipelines#2497. However, the manifests didn't get updated and, therefore, the issue continues in the standard deployment of Kubeflow. This PR just updates the ConfigMap.

Set DB GroupConcatMaxLen config to default of 4MB

942fbcc

k8s-ci-robot added the size/S label Oct 25, 2019

k8s-ci-robot requested review from IronPan and neuromage October 25, 2019 21:58

k8s-ci-robot added the needs-ok-to-test label Oct 25, 2019

krajasek mentioned this pull request Oct 25, 2019

[Pipeline Metrics] Working with more than 2 metrics causes errors #2310

Closed

Ark-kun assigned IronPan Nov 5, 2019

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Nov 5, 2019

Ark-kun reviewed Nov 5, 2019

View reviewed changes

k8s-ci-robot assigned Ark-kun Nov 5, 2019

k8s-ci-robot added the lgtm label Nov 5, 2019

k8s-ci-robot added the approved label Nov 7, 2019

k8s-ci-robot merged commit aa4f1b6 into kubeflow:master Nov 7, 2019

This was referenced Mar 8, 2020

Update ml-pipeline-config ConfigMap to include GroupConcatMaxLen kubeflow/manifests#988

Closed

Update DBConfig.GroupConcatMaxLen in ml-pipeline apiserver config map kubeflow/manifests#989

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set DB GroupConcatMaxLen config to default of 4MB #2497

Set DB GroupConcatMaxLen config to default of 4MB #2497

krajasek commented Oct 25, 2019 •

edited by jlewi

Loading

googlebot commented Oct 25, 2019

k8s-ci-robot commented Oct 25, 2019

krajasek commented Nov 1, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

krajasek commented Nov 4, 2019

krajasek commented Nov 5, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Nov 5, 2019

Ark-kun commented Nov 5, 2019

Ark-kun Nov 5, 2019

Ark-kun commented Nov 5, 2019

Ark-kun commented Nov 6, 2019

krajasek commented Nov 6, 2019

Ark-kun commented Nov 6, 2019

IronPan commented Nov 7, 2019

k8s-ci-robot commented Nov 7, 2019

Set DB GroupConcatMaxLen config to default of 4MB #2497

Set DB GroupConcatMaxLen config to default of 4MB #2497

Conversation

krajasek commented Oct 25, 2019 • edited by jlewi Loading

googlebot commented Oct 25, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

k8s-ci-robot commented Oct 25, 2019

krajasek commented Nov 1, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

krajasek commented Nov 4, 2019

krajasek commented Nov 5, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Nov 5, 2019

Ark-kun commented Nov 5, 2019

Ark-kun Nov 5, 2019

Choose a reason for hiding this comment

Ark-kun commented Nov 5, 2019

Ark-kun commented Nov 6, 2019

krajasek commented Nov 6, 2019

Ark-kun commented Nov 6, 2019

IronPan commented Nov 7, 2019

k8s-ci-robot commented Nov 7, 2019

krajasek commented Oct 25, 2019 •

edited by jlewi

Loading