[Sample] Add the run ID place holder to TFX sample, fix metadb config in preload sample as well #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 21, 2019 15:17
# Conflicts: # manifests/gcp_marketplace/guide.md
|
/hold need to fix |
|
/hold need to fix |
added 2 commits
October 24, 2019 16:32
|
Is the binary file in this PR needed? |
For now, yes, we need a modified/unreleased version of TFX to compile the pipeline correctly. |
|
/hold cancel |
|
/assign @IronPan |
added 2 commits
October 25, 2019 08:45
# Conflicts: # samples/contrib/parameterized_tfx_oss/parameterized_tfx_oss.tar.gz
|
PTAL thanks @IronPan |
numerology
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By plugging in automatically generated workflow ID the user do not need to make sure the pipeline root is clean themselves.
Included some fix to artifact store display as well.
This change is