Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better doc for MKP-KFP deployment #2481

Merged
merged 1 commit into from
Oct 24, 2019
Merged

better doc for MKP-KFP deployment #2481

merged 1 commit into from
Oct 24, 2019

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Oct 24, 2019

  1. how to better handle inverse proxy permission setting
  2. move CLI guide out of main readme and suggest user use UI

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Oct 24, 2019

/lgtm

Looks great to me! Needing one more click to cli documentation sounds like what user should know.

@rmgogogo rmgogogo changed the title better doc better doc for MKP-KFP deployment Oct 24, 2019
@rmgogogo
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link

/retest

1 similar comment
@numerology
Copy link

/retest

@k8s-ci-robot k8s-ci-robot merged commit bb6066a into kubeflow:master Oct 24, 2019
@IronPan
Copy link
Member

IronPan commented Oct 24, 2019

@rmgogogo Accessing the UI won't need the project editor permission as it's not a good pratice for enterprise usecase
it at minimum requires service account user for the service account that creates the proxy. project editor should work but it will grant more access than needed

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants