Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples/core/ai_platform pipeline to follow data dependency #2472

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

ucdmkt
Copy link
Contributor

@ucdmkt ucdmkt commented Oct 23, 2019

Control dependency by .after() is not strictly necessary, because the first component returns outputs to the data path, which is to be used by the second component. Updating this to demonstrate a common practice.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @ucdmkt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ucdmkt
Copy link
Contributor Author

ucdmkt commented Oct 31, 2019

\cc @hongye-sun

@numerology
Copy link

/ok-to-test

@numerology
Copy link

/lgtm
/approve
Thanks @ucdmkt !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d943fee into kubeflow:master Oct 31, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants