Add option to hide tensorboard artifact #2466
Conversation
|
Hi @hlu09. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @hongye-sun |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -18,14 +18,15 @@ | |||
| from ._client import MLEngineClient | |||
| from .. import common as gcp_common | |||
|
|
|||
| def wait_job(project_id, job_id, wait_interval=30): | |||
| def wait_job(project_id, job_id, wait_interval=30, show_tensorboard=True): | |||
There was a problem hiding this comment.
show_tensorboard=True
Is it set to False anywhere?
There was a problem hiding this comment.
It will be set to False when we use wait-job for non-training cmle jobs.
arguments=[
"kfp_component.google.ml_engine",
"wait-job",
"--project_id",
gcp_project_id,
"--job_id",
job_id,
"--wait_interval",
wait_interval_in_seconds,
"--show_tensorboard",
"False",
],
|
/retest |
1 similar comment
|
/retest |
* Feat: add huggingface bloom example to torchserve Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * fix: add pv and helper pod yaml - update readme doc - add storageclass yaml - fix config.properties Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> * fix: add steps for model sharding
For CMLE steps associated with a gcs folder, only train step shall show Tensorboard. Thus add option to avoid outputting a Tensorboard artifact.
This change is