[Frontend] UI shows specified task display name in PipelineDetail page #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve @numerology please LGTM if this looks good |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Decided to merge first because I will reformat all frontend code. |
|
/lgtm |
|
/lgtm |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…kubeflow#2459) * adding prometheus port configs for aggregating metrics in queue proxy Signed-off-by: alexagriffith <agriffith50@bloomberg.net> * change tensorflow metrics port to 8080 Signed-off-by: alexagriffith <agriffith50@bloomberg.net> * resolving comments Signed-off-by: alexagriffith <agriffith50@bloomberg.net> * setting the tensorflow prom port to the rest api port Signed-off-by: alexagriffith <agriffith50@bloomberg.net> Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The display name shall be retrievable from metadata.annotations.pipelines.kubeflow.org/task_display_name from each components in workflow yaml spec.
For review, use this link to avoid seeing unrelated format changes.
Before the fix:
After the fix:
/area front-end
/kind feature
/cc @numerology
This change is